fix: preserve path separators in create command argument by srtaalej · Pull Request #526 · slackapi/slack-cli

srtaalej · 2026-05-07T21:16:32Z

Changelog

semver:patch — The create command preserves path separators when a nested path is provided as the project directory. The --name flag now only overrides the app's display name in the manifest without replacing the path argument.

$ slack create path/to/my-app --name "My App"
# Creates directory at ./path/to/my-app/ with manifest name "My App"

Summary

Fixes the slack create path/to/my-app regression where path separators were being replaced with dashes, creating a flat path-to-my-app directory instead of preserving the path/to/my-app structure
Adds parseAppPath helper that splits user input into path prefix + basename, only kebab-casing the basename
Display name for manifests is derived from the raw basename (not the full path)
The --name flag now sets only the manifest display name, preserving any path from the positional argument

Behavior

$ slack create my-app              # dir: ./my-app/        manifest: "my-app"
$ slack create "My App"            # dir: ./my-app/        manifest: "My App"
$ slack create path/to/my-app      # dir: ./path/to/my-app/ manifest: "my-app"
$ slack create path/to/My App      # dir: ./path/to/my-app/ manifest: "My App"
$ slack create path/to/my-app --name "APPPP"  # dir: ./path/to/my-app/ manifest: "APPPP"

Stacks on #521 which handles the display name vs dir name separation.

Test plan

TestParseAppPath — 12 cases covering simple names, paths, absolute paths, dot-prefixed, trailing slashes, and error cases
Existing TestGetProjectDirectoryName still passes (single-component names)
Full test suite (go test ./...) passes
Updated --name flag tests to verify path is preserved and only display name is overridden
Manual: slack create path/to/my-app with existing path/to/ directory → verify nested structure created and manifest has my-app
Manual: slack create "My App" → verify dir is my-app, manifest display is My App
Manual: slack create path/to/my-app --name "APPPP" → verify dir is path/to/my-app, manifest display is APPPP

The display_information.name and bot_user.display_name fields in manifest files were set to the kebab-case directory name (e.g. "my-app") instead of a human-readable title case name (e.g. "My App").

…ebab Addresses review feedback — instead of converting the kebab-case directory name to title case (which mangles names like "TIM" or "Translator - Translate Languages"), pass the original user-provided app name through to manifest display fields. This preserves the user's exact casing and formatting.

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

The getAppDirName function was normalizing the entire input including path separators, so `slack create path/to/my-app` produced a flat directory `path-to-my-app` instead of preserving the path structure. Adds parseAppPath which splits user input into path prefix and basename, only kebab-casing the basename. The display name for manifests is derived from the raw basename (preserving original casing). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

codecov · 2026-05-07T21:20:08Z

Codecov Report

❌ Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (59d720d) to head (7e4d486).

Files with missing lines	Patch %	Lines
internal/pkg/create/create.go	61.90%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   71.30%   71.32%   +0.01%     
==========================================
  Files         222      222              
  Lines       18695    18714      +19     
==========================================
+ Hits        13331    13348      +17     
- Misses       4184     4186       +2     
  Partials     1180     1180

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg

@srtaalej Thank you for bringing a fix to PR! I'm leaving a comment of another case to consider with this but I'm eager to get this merged 🚀

zimeg · 2026-05-11T17:18:11Z

 	// Verify that the parent directory path exists (we will not create missing directories)
 	if exists, err := parentDirExists(dirPath); err != nil {
 		return "", err
 	} else if !exists {
 		return "", slackerror.New(slackerror.ErrAppDirectoryAccess)
 	}


🔬 thought: So curious! I thought creating missing directories was supported but I am wrong!

yes very curious! i thought so too but i think it would be nice to have 🤔 perhaps in followups 🚀

zimeg · 2026-05-11T17:22:32Z

-	// Get the app selection and accompanying app directory name (this may change when we find the unique directory name)
-	appDirName, err := getAppDirName(createArgs.AppName)
+	// Parse the app name input into a directory path and display name
+	appPath, displayName, err := parseAppPath(createArgs.AppName)


🐛 issue: I'm finding the app path can be changed with the "--name" flag which is unexpected as:

$ slack create path/to/my-app --name "APPPP" 📂 Created a new Slack project Cloning template slack-samples/bolt-js-starter-template To path ~/programming/tools/slack-cli/apppp

🔍 thought: I'd instead expect the argument path to be preferred here with the name being applied to the app itself? I'm unsure if separating these functions makes this more clear but think this case is good to test too!

hmmm i thought the --name flag was always preferred? this was introduced with the name flag in #327
but thanks for catching this because i would also expect --name to override the display name and leave the path alone

@srtaalej Ahh we might be finding nuance of this command 😓 I recall these discussion too and didn't account for these edges...

The --name flag now only sets the manifest display name, preserving any path provided via the positional argument for directory placement.

zimeg

🔮 @srtaalej This gets to a great place! I'm leaving a handful more comments that I hope untangle some arguments but find this is a nice fix-

Uppercase directories: Earlier change lowercased path to directories too in normalization but downstream issues are noticed from this, albeit with workarounds. I note that it might be a nice change for a separate PR!
App path placement: The "app name" argument feels outdated now that we're supporting "display name" too. A more meaningful change to perhaps make in this PR centralizes some of this logic but I think we can save other refactors?

I'm approving now but feel free to rerequest review if refactors feel awkward!

zimeg · 2026-05-11T21:32:16Z

 		return "", fmt.Errorf("app name is required")
 	}

 	// Normalize to kebab-case: lowercase, replace non-alphanumeric with dashes, collapse, and trim


Suggested change

// Normalize to a variation of kebab-case: replace non-alphanumeric with dashes, collapse, and trim

🌠 issue(non-blocking): The lowercasing might be confusing to CI that creates apps with a random name. We might consider keeping uppercase to match inputs that make a valid directory?

$ pwd ~/Documents $ slack create MyApp ... To path ~/Documents/myapp

zimeg · 2026-05-11T21:32:34Z


 	// Normalize to kebab-case: lowercase, replace non-alphanumeric with dashes, collapse, and trim
 	appName = strings.TrimSpace(appName)
 	appName = strings.ToLower(appName)


Suggested change

🪓 suggestion(non-blocking): With the above comment I share this.

zimeg · 2026-05-11T21:56:32Z

+	// --name flag overrides the manifest display name but preserves any path
+	// from the positional argument. When no positional arg is given (e.g.
+	// "slack create --name APPPP"), the name flag also becomes the directory
+	// path since there's nothing else to derive it from.
+	displayNameOverride := ""
 	if nameFlagProvided {
-		appNameArg = createAppNameFlag
+		displayNameOverride = createAppNameFlag
+		if appNameArg == "" {
+			appNameArg = createAppNameFlag
+		}


🪴 suggestion: We might want to move this alongside logic below with some shuffling:

slack-cli/cmd/project/create.go

Lines 148 to 166 in 7e4d486

// Prompt for app name if not provided via flag or argument

if appNameArg == "" {

if clients.IO.IsTTY() {

defaultName := generateRandomAppName()

name, err := clients.IO.InputPrompt(ctx, "Name your app:", iostreams.InputPromptConfig{

Placeholder: defaultName,

})

if err != nil {

return err

}

if name != "" {

appNameArg = name

} else {

appNameArg = defaultName

}

} else {

appNameArg = generateRandomAppName()

}

}

zimeg · 2026-05-11T22:00:58Z

-		Template:  template,
-		GitBranch: createGitBranchFlag,
-		Subdir:    subdir,
+		AppName:     appNameArg,


🪬 thought: The meaning of these arguments has inverted for me and I now think about this variable as the app path that might be used for the app name defaults. The path separators of this PR must have inspired such idea!

🔮 suggestion(follow-up): We might find it useful to update this but I'd like to know if I'm thinking about this right?

Suggested change

AppName: appNameArg,

AppPath: appPathArg,

zimeg · 2026-05-11T22:08:59Z

+	// from the positional argument. When no positional arg is given (e.g.
+	// "slack create --name APPPP"), the name flag also becomes the directory
+	// path since there's nothing else to derive it from.
+	displayNameOverride := ""


Suggested change

displayNameOverride := ""

displayName := ""

🔬 suggestion: I understand within pkg this overrides a parsed path but that term might be confusing from this calling code.

srtaalej and others added 5 commits May 4, 2026 16:04

fix: use title case for manifest display names during app creation

7e47fee

The display_information.name and bot_user.display_name fields in manifest files were set to the kebab-case directory name (e.g. "my-app") instead of a human-readable title case name (e.g. "My App").

Update test/testdata/manifest-app-name.ts

e0c3bb0

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

liinter errors

39cdaad

srtaalej requested a review from a team as a code owner May 7, 2026 21:16

srtaalej added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels May 7, 2026

srtaalej self-assigned this May 7, 2026

Base automatically changed from ale-fix-display-name-casing to main May 8, 2026 15:22

srtaalej and others added 4 commits May 8, 2026 12:21

merge: resolve conflict with main after PR #521

eed95a8

Merge branch 'main' into ale-fix-create-path-regression

3ed0b6f

test: cover accessible mode branch in buildPasswordForm

fca83ad

fix: remove unrelated password form tests from this branch

8c6c53b

zimeg added the changelog Use on updates to be included in the release notes label May 11, 2026

zimeg added this to the Next Release milestone May 11, 2026

Merge branch 'main' into ale-fix-create-path-regression

1026d94

zimeg reviewed May 11, 2026

View reviewed changes

Comment thread internal/iostreams/forms_test.go Outdated

style: remove blank line

bdeadda

zimeg self-requested a review May 11, 2026 16:48

zimeg requested changes May 11, 2026

View reviewed changes

srtaalej and others added 2 commits May 11, 2026 15:50

fix: --name flag overrides display name without replacing path argument

cf6a674

The --name flag now only sets the manifest display name, preserving any path provided via the positional argument for directory placement.

Merge branch 'main' into ale-fix-create-path-regression

7e4d486

srtaalej requested a review from zimeg May 11, 2026 20:37

zimeg approved these changes May 11, 2026

View reviewed changes


	// Normalize to a variation of kebab-case: replace non-alphanumeric with dashes, collapse, and trim

	// Prompt for app name if not provided via flag or argument
	if appNameArg == "" {
	if clients.IO.IsTTY() {
	defaultName := generateRandomAppName()
	name, err := clients.IO.InputPrompt(ctx, "Name your app:", iostreams.InputPromptConfig{
	Placeholder: defaultName,
	})
	if err != nil {
	return err
	}
	if name != "" {
	appNameArg = name
	} else {
	appNameArg = defaultName
	}
	} else {
	appNameArg = generateRandomAppName()
	}
	}

Conversation

srtaalej commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Behavior

Test plan

Uh oh!

codecov Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srtaalej May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srtaalej commented May 7, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited

Loading

srtaalej May 11, 2026 •

edited

Loading